Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

telemetry, session: add telemetry collector for placement policies #33165

Merged
merged 4 commits into from
Mar 17, 2022
Merged

telemetry, session: add telemetry collector for placement policies #33165

merged 4 commits into from
Mar 17, 2022

Conversation

bb7133
Copy link
Member

@bb7133 bb7133 commented Mar 16, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #33188

Problem Summary:

What is changed and how it works?

Add telemetry support.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@bb7133 bb7133 added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 16, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 16, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • lcwangchao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 16, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Mar 16, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/582c11d38186a6dbeb8f175aeb28cd46104ed691

@bb7133 bb7133 force-pushed the bb7133/placement_telemetry branch 2 times, most recently from 6e544ff to dede279 Compare March 16, 2022 16:54
lcwangchao
lcwangchao reviewed Mar 16, 2022
View reviewed changes
telemetry/data_feature_usage.go Outdated
NumPlacementPolicies uint64
NumDBWithPolicies uint64
NumTableWithPolicies uint64
NumPartitionWithPoliciess uint64
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
NumPartitionWithPoliciess uint64
NumPartitionWithPolicies uint64

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved, thanks.

lcwangchao
lcwangchao reviewed Mar 16, 2022
View reviewed changes
telemetry/data_feature_usage.go Outdated
}
for _, partitionInfo := range partitions.Definitions {
if partitionInfo.PlacementPolicyRef != nil {
usage.PlacementPolicyUsage.NumPartitionWithPoliciess++
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is NumPartitionWithPolicies mean ? If a table has placement policy, all its partitions should have placement policies.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated it to NumPartitionWithExplicitPolicies with a comment.

@bb7133 bb7133 force-pushed the bb7133/placement_telemetry branch from c771a1b to ddc94a6 Compare March 17, 2022 04:09
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 17, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 17, 2022
@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ddc94a69160054198f5df6c2381204b94bad9ac6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 17, 2022
@bb7133 bb7133 force-pushed the bb7133/placement_telemetry branch from 6322624 to 82a8fbd Compare March 17, 2022 04:19
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Mar 17, 2022
@bb7133
Copy link
Member Author

bb7133 commented Mar 17, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 82a8fbdc2306057f46b929bdc3ef4824688480d8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 17, 2022
@bb7133 bb7133 force-pushed the bb7133/placement_telemetry branch from 3e52707 to b623332 Compare March 17, 2022 05:19
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Mar 17, 2022
@bb7133
Copy link
Member Author

bb7133 commented Mar 17, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b623332

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 17, 2022
@bb7133
Copy link
Member Author

bb7133 commented Mar 17, 2022

/merge

@ti-chi-bot
Copy link
Member

@bb7133: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit eb4cfce into pingcap:master Mar 17, 2022
@bb7133 bb7133 deleted the bb7133/placement_telemetry branch March 17, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@lcwangchao lcwangchao lcwangchao approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support telemetry for "Placement Rules in SQL"
6 participants
@bb7133 @ti-chi-bot @sre-bot @hawkingrei @lcwangchao @tiancaiamao